fix jetstream client certificate mount path #2167
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhoherd
reviewed
Apr 2, 2024
| @@ -99,7 +99,7 @@ def test_nats_statefulset_with_jetstream_and_tls(self, kube_version): | |||
| } in docs[10]["spec"]["template"]["spec"]["containers"][0]["volumeMounts"] | |||
| assert { | |||
| "name": "nats-jetstream-client-tls-volume", | |||
| "mountPath": "/usr/local/share/ca-certificates/release-name-jetstream-tls-certificate-client/ca.crt", | |||
| "mountPath": "/usr/local/share/ca-certificates/release-name-jetstream-tls-certificate-client.crt", | |||
There was a problem hiding this comment.
We need a test with a custom nats.jetstreamSSLSecretName
There was a problem hiding this comment.
I missed this one - let me add test case for custom cert as well
There was a problem hiding this comment.
@danielhoherd jetstreamSSLSecretName this seems require additional changes - can i address this in a seperate PR - template is not rendering with provided values and this seems like byo certficate
danielhoherd
requested changes
Apr 2, 2024
pgvishnuram
changed the title
pgvishnuram
changed the title
danielhoherd
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where mounted client side tls are not respected by the system path due long nested path.
Related Issues
https://github.com/astronomer/issues/issues/6259
Testing
QA should not see any TLS error in nats service
Merging
cherry-pick to release-0.34