Skip to content

Minor api cleanup #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

Minor api cleanup #79

merged 4 commits into from
Jul 11, 2025

Conversation

mwcraig
Copy link
Member

@mwcraig mwcraig commented Jul 11, 2025

Turns out there were a few things that needed to be addressed:

  • Several catalog style tests used shape names that are not part of the API.
  • One test deliberately loaded a catalog without x/y columns, indicated that the x/y columns should be used (as opposed to sky coord), for an image with no wcs, and did not expect the code to raise an error. That is...silly.

mwcraig added 4 commits July 11, 2025 11:33
@mwcraig
Change catalog_names to catalog_labels for consistency
402d635
@mwcraig
Clarify that loading a catalog for an existing catalog replaces the data
87b0116
@mwcraig
Use only valid marker shapes in test
ab383e1
@mwcraig
Fix illogical test
711b664 
This had tested what would happen if you wanted to use x/y for a catalog
but had no x/y in the catalog table and didn't expect that to raise an
error.
@mwcraig mwcraig force-pushed the minor-api-cleanup branch from 7ab7648 to 711b664 Compare July 11, 2025 18:33
@mwcraig mwcraig merged commit c5b86dc into astropy:main Jul 11, 2025
7 checks passed
@mwcraig mwcraig deleted the minor-api-cleanup branch July 11, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mwcraig