Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlinking fits2bitmap in changelog (as it caused docs build failure) #4518

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 21, 2016

No description provided.

@mhvk
Copy link
Contributor

mhvk commented Jan 21, 2016

See duplicate in #4519 - either one will do!

@bsipocz
Copy link
Member Author

bsipocz commented Jan 21, 2016

There are some more warnings, but #4515 should fix those.

@eteq eteq modified the milestones: v1.0.9, v1.1.2 Jan 21, 2016
@eteq
Copy link
Member

eteq commented Jan 21, 2016

Looks good and straightforward, so I'm merging. Thanks to both @bsipocz and @saimn - we're all winners here ;)

eteq added a commit that referenced this pull request Jan 21, 2016
Unlinking fits2bitmap in changelog (as it caused docs build failure)
@eteq eteq merged commit 24d89a6 into astropy:master Jan 21, 2016
eteq added a commit that referenced this pull request Jan 21, 2016
Unlinking fits2bitmap in changelog (as it caused docs build failure)
@eteq
Copy link
Member

eteq commented Jan 21, 2016

backported to v1.1.x in bf523cd

@embray embray added the Docs label Jan 27, 2016
@embray
Copy link
Member

embray commented Jan 27, 2016

Related to this, I just noticed that in http://docs.astropy.org/en/stable/development/workflow/development_workflow.html#add-a-changelog-entry the example of how to write a changelog entry uses single-backticks, when it should use double (and maybe should explicitly say to always use double for the changelog).

I had hoped one day to fix that as a special case for changelog rendering, but I haven't gotten around to it. Pretty low priority.

embray added a commit to embray/astropy that referenced this pull request Jan 27, 2016
mvnnn pushed a commit to mvnnn/astropy that referenced this pull request Jan 30, 2016
@eteq eteq modified the milestones: v1.0.9, v1.1.2 Mar 1, 2016
eteq added a commit that referenced this pull request Mar 1, 2016
Unlinking fits2bitmap in changelog (as it caused docs build failure)
dhomeier pushed a commit to dhomeier/astropy that referenced this pull request Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants