Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated code from io.fits.header #5020

Merged
merged 3 commits into from Jun 3, 2016

Conversation

@bsipocz
Copy link
Member

bsipocz commented Jun 2, 2016

This is a rebased ad squashed version of #4445 that was milestoned as 1.2.
I believe @embray gave the green light pending the changelog entry back in Jan, thus it would be nice to get this in the release.

Closes #4445, closes #4429 and most probably #2594, too.

cc @eteq @astrofrog

…eader.remove: ``ignore_missing`` and ``all``.
keyword = Card.normalize_keyword(keyword)
if keyword in self._keyword_indices:
del self[self._keyword_indices[keyword][0]]
if all:

This comment has been minimized.

Copy link
@saimn

saimn Jun 3, 2016

Contributor

all is maybe not a so good idea as argument name, as it shadows the builtin all function. Maybe remove_all ?

This comment has been minimized.

Copy link
@bsipocz

bsipocz Jun 3, 2016

Author Member

good point, thanks!

CHANGES.rst Outdated
@@ -208,6 +208,13 @@ New Features

- New function ``convenience.table_to_hdu`` to allow creating a FITS
HDU object directly from an astropy ``Table``. [#4778]

This comment has been minimized.

Copy link
@saimn

saimn Jun 3, 2016

Contributor

Missing newline, + wrap next lines to 80 characters ?

@astrofrog

This comment has been minimized.

Copy link
Member

astrofrog commented Jun 3, 2016

👍

@astrofrog astrofrog merged commit 7ab05eb into astropy:master Jun 3, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 77.085%
Details
astrofrog added a commit that referenced this pull request Jun 3, 2016
Removing deprecated code from io.fits.header
@@ -209,6 +209,9 @@ New Features
- New function ``convenience.table_to_hdu`` to allow creating a FITS
HDU object directly from an astropy ``Table``. [#4778]

- A new optional arguments ``ignore_missing`` and ``remove_all`` are added

This comment has been minimized.

Copy link
@embray

embray Jun 8, 2016

Member

Slight typo here. "A new optional arguments".. Should be reworded.

@embray

This comment has been minimized.

Copy link
Member

embray commented Jun 8, 2016

Thanks @bsipocz and @Pratik151 for the original fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.