Removing deprecated code from io.fits.header #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eader.remove: ``ignore_missing`` and ``all``.
| keyword = Card.normalize_keyword(keyword) | ||
| if keyword in self._keyword_indices: | ||
| del self[self._keyword_indices[keyword][0]] | ||
| if all: |
There was a problem hiding this comment.
all is maybe not a so good idea as argument name, as it shadows the builtin all function. Maybe remove_all ?
|
👍 |
astrofrog
added a commit
that referenced
this pull request
Jun 3, 2016
Removing deprecated code from io.fits.header
| @@ -209,6 +209,9 @@ New Features | |||
| - New function ``convenience.table_to_hdu`` to allow creating a FITS | |||
| HDU object directly from an astropy ``Table``. [#4778] | |||
|
|
|||
| - A new optional arguments ``ignore_missing`` and ``remove_all`` are added | |||
There was a problem hiding this comment.
Slight typo here. "A new optional arguments".. Should be reworded.
|
Thanks @bsipocz and @Pratik151 for the original fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased ad squashed version of #4445 that was milestoned as 1.2.
I believe @embray gave the green light pending the changelog entry back in Jan, thus it would be nice to get this in the release.
Closes #4445, closes #4429 and most probably #2594, too.
cc @eteq @astrofrog