Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zscale code to ZScaleInterval #5514

Merged
merged 3 commits into from
Nov 29, 2016
Merged

Conversation

larrybradley
Copy link
Member

This PR is a followup to #5499 and removes the zscale.py module, placing the code within the ZScaleInterval class. I also removed the numdisplay license because the original code was BSD licenced (see #5499).

@larrybradley larrybradley added this to the v1.3.0 milestone Nov 28, 2016
@pllim
Copy link
Member

pllim commented Nov 28, 2016

So, we don't need a deprecation period for this? Does not look backward compatible.

@larrybradley
Copy link
Member Author

zscale.zscale was never "public" in the sense that it was never in the docs. I'm not sure that we really need to deprecate it. @astrofrog?

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed zscale was never part of the public API on the website, so I think it's safe to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants