Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Column or MaskedColumn name arg be a keyword arg name=None #731

Merged
merged 7 commits into from
Feb 8, 2013

Commits on Feb 5, 2013

  1. Configuration menu
    Copy the full SHA
    f08cfbf View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2013

  1. Configuration menu
    Copy the full SHA
    2a47e25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28ea0a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b999b48 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2013

  1. Check Column/MaskedColumn __new__ args for compliance with 0.3 ordering

    This is implemented as a decorate on __new__(cls, name=None, data=None, ..)
    for Column and MaskedColumn.
    
    The warning is:
    
    In the next major release of astropy (0.3), the order of function
    arguments for creating a {class_name} will change.  Currently the order is
    {class_name}(name, data, ...), but in 0.3 and later it will be
    {class_name}(data, name, ...).  This is consistent with Table and NumPy.
    
    In order to use the same code for Astropy 0.2 and 0.3, column objects
    should be created using named keyword arguments for data and name, e.g.:
    {class_name}(name='a', data=[1, 2]).
    taldcroft committed Feb 7, 2013
    Configuration menu
    Copy the full SHA
    716dde9 View commit details
    Browse the repository at this point in the history
  2. Fix tests so no warnings are generated in Column() calls

    This is only complete for table and io.ascii.  All of these tests
    run without generating warnings.  This was done to be sure that
    all code in astropy.table and astropy.io.ascii is fully compliant
    with the new Column args checking, i.e. it will never happen that
    a call to astropy.Table can generate a warning to the user.
    taldcroft committed Feb 7, 2013
    Configuration menu
    Copy the full SHA
    69ed301 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f91436c View commit details
    Browse the repository at this point in the history