Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stats and contributors to whatsnew #8232

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Adding stats and contributors to whatsnew #8232

merged 4 commits into from
Dec 6, 2018

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Dec 6, 2018

No description provided.

@bsipocz bsipocz added this to the v3.1 milestone Dec 6, 2018
pllim
pllim approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos to adding the name list! 👍 👏

Minor comments but otherwise LGTM.

docs/whatsnew/3.1.rst
* xxx issues have been closed since v3.0
* xxx pull requests have been merged since v3.0
* xxx distinct people have contributed code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

docs/whatsnew/3.1.rst
Contributors to the v3.1 release
================================

.. hlist::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check rendered doc in CircleCI to make sure it renders as expected, as the GitHub preview does not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Otherwise I works for me ™️ 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked this and it rendered fine locally!

docs/whatsnew/3.1.rst Outdated
* Ritiek Malhotra *
* Rocio Kiman *
* Rohan Rajpal *
* SG004 *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joseph Schlitz https://github.com/SG004

@bsipocz
Copy link
Member Author

bsipocz commented Dec 6, 2018

Kudos to adding the name list!

Kudos to @Cadair for helping with the mailmap and extending the procedure script (that we need to add to our procedures, ideally in a PR by him :) )

@pllim
Copy link
Member

pllim commented Dec 6, 2018

we need to add to our procedures, ideally in a PR by him

Should I open an issue? 😉

@pllim
Copy link
Member

pllim commented Dec 6, 2018

Hmm, CircleCI failure. @astrofrog ?

    Complete output from command python setup.py egg_info:
    Beginning with Matplotlib 3.1, Python 3.6 or above is required.
    This may be due to an out of date pip.
    Make sure you have pip >= 9.0.1.

@bsipocz
Copy link
Member Author

bsipocz commented Dec 6, 2018

Hmm, CircleCI failure. @astrofrog ?

I would ignore it for now and go ahead with the release.

@eteq
Copy link
Member

eteq commented Dec 6, 2018

checking the build locally shortly... but the circleci failure appeared on #8222 in just the last few hours, so I agree it's probably ignorable for this PR (it looks like an mpl update happened in the meantime, so we probably just need to pin a version or something).

@bsipocz
Copy link
Member Author

bsipocz commented Dec 6, 2018

@eteq - you can look at giles, no need to build locally.

@pllim
Copy link
Member

pllim commented Dec 6, 2018

I am confused. I don't see the name list at https://circleci.com/gh/astropy/astropy/18377/artifacts/0//home/circleci/project/docs/_build/html/index.html

@bsipocz
Copy link
Member Author

bsipocz commented Dec 6, 2018

@pllim - https://18377-2081289-gh.circle-artifacts.com/0/home/circleci/project/docs/_build/html/whatsnew/3.1.html

@pllim
Copy link
Member

pllim commented Dec 6, 2018

Oh wait, I found it -- https://18377-2081289-gh.circle-artifacts.com/0/home/circleci/project/docs/_build/html/whatsnew/3.1.html but the index points to 3.2 🤷‍♀️

The list rendering is cool! 👍

@bsipocz
Copy link
Member Author

bsipocz commented Dec 6, 2018

@pllim - in the backport 3.1 what's new will be on the index page.

eteq
eteq approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion, which was just easier to do as bsipocz#4, which you can accept or reject as you prefer!

docs/whatsnew/3.1.rst
* xxx pull requests have been merged since v3.0
* xxx distinct people have contributed code

* 906 issues have been closed since v3.0
Copy link
Member

@eteq eteq Dec 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 (i.e., a big number! which is a good thing.)

docs/whatsnew/3.1.rst
* 906 issues have been closed since v3.0
* 437 pull requests have been merged since v3.0
* 94 distinct people have contributed code to this release, 51 of which are
first time contributors to Astropy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

docs/whatsnew/3.1.rst
Contributors to the v3.1 release
================================

.. hlist::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked this and it rendered fine locally!

@bsipocz
Merge pull request #4 from eteq/whatsnew_31
1c8f3d2 
change asterisks to no space
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #8232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8232   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files         383      383           
  Lines       57885    57885           
  Branches     1056     1056           
=======================================
  Hits        50309    50309           
  Misses       6962     6962           
  Partials      614      614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58151fb...1c8f3d2. Read the comment docs.

@bsipocz bsipocz merged commit 0770dea into astropy:master Dec 6, 2018
bsipocz added a commit that referenced this pull request Dec 6, 2018
@bsipocz
Merge pull request #8232 from bsipocz/whatsnew_31
d81b9f9 
Adding stats and contributors to whatsnew
@bsipocz bsipocz deleted the whatsnew_31 branch September 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eteq eteq eteq approved these changes

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
Docs no-changelog-entry-needed Release
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bsipocz @pllim @eteq