-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed OverflowError condition of fast ascii converter to >= |HUGE_VAL| #9738
Changed OverflowError condition of fast ascii converter to >= |HUGE_VAL| #9738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the change @dhomeier suggested before. I successfully tested this on our i386 architecture. What I did not test yet is whether it does harm on other platforms; however it looks simple enough for me.
I am planning to upload the RC2 plus this patch to Debian experimental later today (CET), so if a definitive confirmation for all our platforms is needed, I can give that only tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way beyond my C knowledge, but I don't see how this change could do any harm, so I'm fine with including it since it seems to work.
I feel it's not necessary? 🤷♀ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @dhomeier! |
Changed OverflowError condition of fast ascii converter to >= |HUGE_VAL|
It is already closed, but I just wanted to confirm that this does not harm on our other platforms ;-) |
Addressing #9694 - if we are right about the fast C converter internally calculating in 80 bit on some architectures like x86_64/gcc 9.2 (see discussion there), this will still raise an
OverflowError
when the returned value exceedsnp.float64
range (and becomesinf
).Fix #9694