Added dtype argument to combiner #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crawfordsm -- do you mind if I merge this? The only travis fail was related to an out-of-date |
|
Thanks @heidtna for adding this in! Sorry to take a while to look at this, but can I ask you to add two more things:
It might also be good Although I'm happy if this is done in two steps--merging this pull request and then a second pull request to add the testing and documentation, but I think it would be better to add it in here if easy to do. |
|
Thanks @heidtna, merging this in! |
mwcraig
added a commit
that referenced
this pull request
Oct 31, 2014
Added dtype argument to combiner
mwcraig
added a commit
to mwcraig/ccdproc
that referenced
this pull request
Nov 5, 2014
Added dtype argument to combiner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #176.
Added the argument to reduce memory usage by letting the user specify the dtype, and setting the default at 64 if none is specified.