-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astropy v1.05 #242
Astropy v1.05 #242
Conversation
Should a test be added for this situation and/or should CCDData be made compatible with earlier versions? Also it seems a little odd that data = ... can't be used in astropy.NDDataArray. |
@crawfordsm -- yeah, it is a bit odd. The APE specifies that the first argument is required, which is why I merged the change that is raising the errors for us. I suppose we could override in |
Closes #241 |
Astropy v1.05
Hi, I still seem to get exactly this "tuple index out of range" error, e.g. when I try to run the example ipython notebook. Did I misunderstand something or was this supposed to be fixed? I've tried installing astropy/ccdproc via both conda and pip. |
@lazygun37 -- this was supposed to have been fixed. What version of astropy are you using? |
I'm using
astropy 1.1.2 np110py27_0
ccdproc 1.2.0 py27_0 conda-forge
Thanks!
C
On 29/09/17 17:11, Matt Craig wrote:
@lazygun37<https://github.com/lazygun37> -- this was supposed to have been fixed. What version of astropy are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#242 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEl8gIk9AtBGc00usD3x52KEws2BsbJXks5snRaQgaJpZM4GNShu>.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/astropy/ccdproc","title":"astropy/ccdproc","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png"<https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png>,"avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png"<https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png>,"action":{"name":"Open in GitHub","url":"https://github.com/astropy/ccdproc"<https://github.com/astropy/ccdproc>}},"updates":{"snippets":[{"icon":"PERSON","message":"@mwcraig in #242: @lazygun37 -- this was supposed to have been fixed. What version of astropy are you using?"}],"action":{"name":"View Pull Request","url":"#242 (comment)"<https://github.com/astropy/ccdproc/pull/242#issuecomment-333169596>}}}
…--
===================================================
Professor Christian Knigge
Physics & Astronomy
University of Southampton
Southampton SO17 1BJ
====================================================
|
Some progress -- the problem is something to do with the "data" keyword -- more specifically with its name being "data". For example, if img is a valid image (i.e. a 2D array), the following falls over for me with the tuple index error: ccdproc.CCDData(data=img) but simply deleting "data" as in ccdproc.CCDData(data=img) works just fine... |
Update to ccdproc to take account of issues created with the merging into astorpy 1.05 of astropy/astropy#4130 and #241. CCDData should still be backward compatible with earlier versions of astropy, but any code that uses CCDData(data=...) format will be broken.