Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astropy v1.05 #242

Merged
merged 5 commits into from
Oct 13, 2015
Merged

Astropy v1.05 #242

merged 5 commits into from
Oct 13, 2015

Conversation

crawfordsm
Copy link
Member

Update to ccdproc to take account of issues created with the merging into astorpy 1.05 of astropy/astropy#4130 and #241. CCDData should still be backward compatible with earlier versions of astropy, but any code that uses CCDData(data=...) format will be broken.

@crawfordsm
Copy link
Member Author

Should a test be added for this situation and/or should CCDData be made compatible with earlier versions? Also it seems a little odd that data = ... can't be used in astropy.NDDataArray.

@mwcraig
Copy link
Member

mwcraig commented Oct 12, 2015

@crawfordsm -- yeah, it is a bit odd. The APE specifies that the first argument is required, which is why I merged the change that is raising the errors for us. I suppose we could override in CCDData....increasingly, I'm thinking the whole NDData edifice is a little unstable.

@crawfordsm crawfordsm closed this Oct 13, 2015
@crawfordsm crawfordsm reopened this Oct 13, 2015
@crawfordsm
Copy link
Member Author

Closes #241

crawfordsm added a commit that referenced this pull request Oct 13, 2015
@crawfordsm crawfordsm merged commit aee0777 into astropy:master Oct 13, 2015
@crawfordsm crawfordsm deleted the astropy_v1.05 branch October 13, 2015 19:29
mwcraig pushed a commit to mwcraig/ccdproc that referenced this pull request Oct 24, 2015
@lazygun37
Copy link

Hi, I still seem to get exactly this "tuple index out of range" error, e.g. when I try to run the example ipython notebook. Did I misunderstand something or was this supposed to be fixed? I've tried installing astropy/ccdproc via both conda and pip.

@mwcraig
Copy link
Member

mwcraig commented Sep 29, 2017

@lazygun37 -- this was supposed to have been fixed. What version of astropy are you using?

@lazygun37
Copy link

lazygun37 commented Sep 30, 2017 via email

@lazygun37
Copy link

Some progress -- the problem is something to do with the "data" keyword -- more specifically with its name being "data". For example, if img is a valid image (i.e. a 2D array), the following falls over for me with the tuple index error:

ccdproc.CCDData(data=img)

but simply deleting "data" as in

ccdproc.CCDData(data=img)

works just fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants