Banner #261
Merged
Banner #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #214 |
|
Looks like it built, so I'm merging -- didn't see anything missing when I looked over the file changes. |
mwcraig
added a commit
that referenced
this pull request
Dec 14, 2015
|
Weird, got the same fail as in #258 when I merged, even though it didn't fail in the PR. In any event, have found the root cause of that problem, will open a PR to fix shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add all of the files needed so that the top banner uses the ccdproc image and ccdproc name. @mwcraig can you check that I have not forgot any files but that these does build fine?
edit: closes #214 (github only pays attention to this in commit messages or the body of the PR).