Ensure column order in ImageFileCollection matches the order of keywords in constructor #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, think I made it worse... |
|
Merging to kill this bug... |
mwcraig
added a commit
that referenced
this pull request
Dec 17, 2015
Ensure column order in ImageFileCollection matches the order of keywords in constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this clarifies the docstring a bit to explain how column order is determined.
The only case in which it is determined by the order of the keywords passed to the constructor is when the wildcard
*is not used.Otherwise the column order is the order in which the keywords appear in the first FITS file opened.