Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the generic ci-helpers script #506

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 7, 2017

Using the generic script will allow us to put more generic stuff in there without code repetition, e.g. the checks for the custom tags and skipping the builds early.

@bsipocz bsipocz changed the title Use the generic ci-helpers script, it will figure out OS [skip appveyor] Use the generic ci-helpers script Jun 7, 2017
Copy link
Member

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just waiting for CI to finish...

@bsipocz
Copy link
Member Author

bsipocz commented Jun 7, 2017

No particular need for that, it worked in all the other repos.

@bsipocz
Copy link
Member Author

bsipocz commented Jun 7, 2017

(I've managed to make a big traffic jam on travis with these mass PRs...)

@MSeifert04
Copy link
Contributor

LGTM;

I made an attempt to fix the failure in #507 .

@mwcraig mwcraig merged commit a738c66 into astropy:master Jun 8, 2017
@MSeifert04 MSeifert04 added this to the 1.3 milestone Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants