Make PEP8 fixes to test_combiner.py
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcraig
force-pushed
the
pep8-fixes-test-combiner
branch
from
44ea6b5
to
6633949
Compare
|
No idea why coveralls thinks coverage went down...I think this is ok to merge @crawfordsm and @MSeifert04 but I'll let one of you hit the button in case there is something I'm missing.... |
MSeifert04
approved these changes
Aug 16, 2018
ccdproc/tests/test_combiner.py
Outdated
| @@ -204,7 +204,9 @@ def test_combiner_average(ccd_data): | |||
| assert ccd.unit == u.adu | |||
| assert ccd.meta['NCOMBINE'] == len(ccd_list) | |||
|
|
|||
| #test that the sum combination works and returns a ccddata object | |||
| # test that the sum combination works and returns a ccddata object | |||
|
|
|||
There was a problem hiding this comment.
I think the two empty lines should be above the comment, not below.
There was a problem hiding this comment.
Thanks, thought I had caught all of those...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My editor happened to notice these so I fixed them....