Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get auth docs building #194

Merged
merged 2 commits into from
May 5, 2020
Merged

Get auth docs building #194

merged 2 commits into from
May 5, 2020

Conversation

cbanek
Copy link
Contributor

@cbanek cbanek commented Nov 13, 2019

For some reason, the docstrings for the auth classes aren't
being built into the docs. Add a link from the main page to
get things generated.

@cbanek cbanek added this to the v1.1 milestone Nov 13, 2019
For some reason, the docstrings for the auth classes aren't
being built into the docs.  Add a link from the main page to
get things generated.
@cbanek
Copy link
Contributor Author

cbanek commented Nov 13, 2019

So here's the build error that has me perplexed:

/home/travis/build/astropy/pyvo/docs/auth/index.rst.rst:19:autosummary: stub file not found 'pyvo.auth.authsession.AuthURLs'. Check your autosummary_generate setting.
Sphinx Documentation subprocess failed with return code 2

So, it should be pyvo.auth.authurls.AuthURLs is the python import path for that module, not authsession. I'm not sure where it's getting this path or how it is generating it, but obviously I am doing something wrong here.

@jonathansick
Copy link

jonathansick commented Nov 13, 2019

Hey @cbanek ! At the top of authsession.py, add this:

__all__ = ('AuthSession',)

What's going on is that automodapi thingk AuthURLs and CredentialStore are defined in authsession.py because they're imported into the namespace for that module. Using the __all__ curates that namespace to just the stuff that the authsession module itself defines.

You might also want to import AuthSession, AuthURLs, and CredentialStore into the __init__.py of pyvo.auth and then have one automodapi directive pointing at that namespace — but that's an API design decision.

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #194 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   70.81%   70.86%   +0.05%     
==========================================
  Files          37       38       +1     
  Lines        3906     3913       +7     
==========================================
+ Hits         2766     2773       +7     
  Misses       1140     1140
Impacted Files Coverage Δ
pyvo/auth/__init__.py 100% <100%> (ø)
pyvo/auth/credentialstore.py 92.1% <100%> (+0.21%) ⬆️
pyvo/auth/authurls.py 80.85% <100%> (+0.41%) ⬆️
pyvo/auth/authsession.py 92.3% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f64f9...2040f78. Read the comment docs.

Copy link
Contributor

@funbaker funbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally ok, just a small remark: examples are still missing.

@andamian andamian merged commit 1935280 into astropy:master May 5, 2020
@andamian
Copy link
Contributor

andamian commented May 5, 2020

@cbanek Merged this - finally. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants