Added 2-d HiPS dask array class and fix a number of bugs with HiPS generation #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
hips2d-dask-array
branch
from
a68902d to
0f72da4
Compare
…class and fix a number of issues that came up including in the generation of HiPS
…images and re-instate generation of lower resolution tiles
astrofrog
force-pushed
the
hips2d-dask-array
branch
from
0f72da4 to
517c360
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 88.30% 89.15% +0.84%
==========================================
Files 28 29 +1
Lines 1411 1549 +138
==========================================
+ Hits 1246 1381 +135
- Misses 165 168 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am not going to add narrative docs about this yet because for it to be truly useful in reproject we need to address #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a round-tripping test starting from an image, going to HiPS, and the reprojecting back through the dask class, which unveiled a number of bugs!
(this is extracted and modified from #514)