fixed bug for highest flux at start or end of spectrum #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eteq
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
LGTM except for one very minor thing - so approving, although @brechmos-stsci might want to make the small adjustment before we merge this.
specutils/tests/test_analysis.py
Outdated
| @@ -460,6 +460,23 @@ def test_fwhm(): | |||
| assert quantity_allclose(result, expected, atol=0.01*u.GHz) | |||
|
|
|||
|
|
|||
| # Highest point at the first point | |||
| frequencies = np.linspace(1, 10, 100) * u.um | |||
There was a problem hiding this comment.
(minor) this isn't actually a frequency - it's a wavelength, so the variable name is a bit confusing
SaOgaz
pushed a commit
that referenced
this pull request
Mar 25, 2019
Fix for checking file existence if it is a comma separated list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with a spectrum where the highest flux was at the beginning of the spectrum. This meant the
leftwas empty which caused some issues. This should now be fixed in this code.Fixes #374