Support serialization of Spectrum1D and SpectrumList to ASDF #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmearl
reviewed
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
drdavella
force-pushed
the
asdf-support
branch
from
e1906a9
to
a21957b
Compare
nmearl
approved these changes
Feb 6, 2019
|
Looks good. |
drdavella
force-pushed
the
asdf-support
branch
2 times, most recently
from
9ab6a16
to
815b9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ASDF tag implementations and schemas in order to enable
Spectrum1DandSpectrumListobjects to be serialized to ASDF files.It turns out that the
asdfpackage is already an indirect package ofspecutilssince it's a dependency ofgwcs. However, I added a bit of logic here to ensure that the test suite continues to pass even ifasdfis not installed. Maybe the correct solution is simply to addasdfas an explicit dependency now, though?This resolves #442.