Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce stricter initalizer for Spectrum1D #513

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Introduce stricter initalizer for Spectrum1D #513

merged 2 commits into from
Sep 17, 2019

Conversation

nmearl
Copy link
Contributor

@nmearl nmearl commented Sep 13, 2019

Addresses #466.

@nmearl nmearl requested a review from eteq September 13, 2019 17:43
@nmearl nmearl added this to the v0.6 milestone Sep 17, 2019
brechmos
brechmos approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@brechmos brechmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nmearl nmearl merged commit b98c349 into astropy:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brechmos brechmos brechmos approved these changes

@eteq eteq Awaiting requested review from eteq

@brechmos-stsci brechmos-stsci Awaiting requested review from brechmos-stsci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmearl @brechmos