Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splicing Docs #536

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Splicing Docs #536

merged 4 commits into from
Oct 15, 2019

Conversation

robelgeda
Copy link
Contributor

@robelgeda robelgeda commented Oct 10, 2019

Related to #254
This PR adds a Splicing section to the docs.

@eteq
Copy link
Member

eteq commented Oct 15, 2019

@robelgeda - while reviewing this I realized I wanted to see the plot of the result of this example, so I tested it out locally (see the commit I pushed up for how I implemented adding a plot to the end of what you wrote). In the process, though, I realized what was implemented was not actually a splice - splicing a spectrum means the two pieces of the spectrum should be non-overlapping, which was not the case in your original example. It was a small modification to what you had to adjust the grids a bit to make it a splice though. So I just did this in 2f9ac1b and pushed it up since my understanding is that you are not free to work on this for the next few weeks. But I think with my modifications this is now ready assuming the tests pass.

@robelgeda
Copy link
Contributor Author

Thanks a lot @eteq!

@eteq
Copy link
Member

eteq commented Oct 15, 2019

The failures are unrelated and due to my re-running the tests, but the important ones all passed, so merging!

@eteq eteq merged commit dadab3b into astropy:master Oct 15, 2019
@nmearl nmearl added this to the v0.7 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants