Simplify pretty_print_contract and introduce newline between contract heads #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asummers
reviewed
Aug 21, 2018
lib/erlex.ex
Outdated
|
|
||
| head = | ||
| head = | ||
| if tail != [] do |
There was a problem hiding this comment.
Can you flip these clauses so this is a positive conditional?
There was a problem hiding this comment.
Actually case is probably more expressive here.
There was a problem hiding this comment.
Either case or Enum.empty?/1. Both are fine to me.
|
This looks good after that one minor comment. I'll get this merged and deployed to Hex later this evening. Thanks for taking care of this! |
|
Curious why circle didn't run... I'll have to look into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request simplifies
pretty_print_contract/1,3by reducing the case without multiple contracts/heads to the case of multiple contracts. It then adds a newline to separate multiple contracts.Fix #3.