-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layout improve #76
layout improve #76
Conversation
GingerBear
commented
Jun 16, 2020
- this should fix Occasional annotation highlight missmatching. #74. the reason it's off is because the div used for text calculate is 20px larger than the actual div that display the text.
- this PR also made some improvement over the line break for text that contains new line character. for example of the one in Occasional annotation highlight missmatching. #74
- this PR also made some improvement over text lines that does't have annotations, so that no extra lines are inserted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems in the previous issues are fixed. But it looks like there are two residual problems
- Selecting one of the legends seems to add too many new lines. See the comparison of the following two screenshots. After selecting the WikiSection legend, there is several more new lines before "See also"
- If we narrow the browser window a bit more, somehow the calculation of the annotation is off again (smaller than the actual text length).
fixed the second issue. For the first issue, the extra space was kept for display lines and text label, it's not smart enough to further adjust by the context when those doesn't exist. Let's keep that for another time to fix. |
Just tested it, looks OK now.
Yeah. Let me create another issue for this. |
this is a good example for that we need more examples to make the tools better |
already created at #77 |
Thanks. I think this PR looks good, will merge it. Btw, I will also create an Issue template to help other people understand thee. |