Add support for generating a standalone package #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
out_of_tree_generation
branch
from
4e85d74 to
4025981
Compare
This avoids duplicating the logic in the 2 writers (with slightly different implementation) and will allow swapping the resolver for standalone packages.
The generate.php script in the code generator does not make sense as an executable as it defaults to reading the manifest and generating the code in the code generator folder itself, which is not the actual use case. Configuring it through environment variables also makes it harder to configure objects like the directory resolver.
This resolver supports the use case of generating a standalone package containing only one service, where the package is at the root of the repository.
stof
force-pushed
the
out_of_tree_generation
branch
from
4025981 to
3caaf58
Compare
jderusse
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code generator usable outside the async-aws mono-repo by allowing to customize the resolution of the directory corresponding to a given namespace. For standalone packages, we want to write the generated service directly in the root of the repository and the root namespace needs to be configurable (as it won't be an AsyncAws one).