Skip to content

Conversation

surechen
Copy link
Contributor

No description provided.

@Keruspe
Copy link
Member

Keruspe commented Jan 10, 2021

Heh, indeed. Actually, even with the typo fixed, it looks wrong, sounds like some copy/paste/edit fail, should just be rewritten

@surechen
Copy link
Contributor Author

Thanks a lot.
I think because this name is used for 'thread::Builder::name'. And in 'Builder' the annotation is:

  • [name]: specifies an [associated name for the thread][naming-threads]
    pub struct Builder {
    // A name for the thread-to-be, for identification in panic messages
    name: Option,
    ........
    }
    Does this looks better ?
    /// The closure function used to get the name of the thread. The name can be used for identification in panic messages.

@Keruspe
Copy link
Member

Keruspe commented Jan 11, 2021

Sure! Thanks for noticing that and taking the time to fix it :)

@Keruspe Keruspe merged commit b19d9bb into async-rs:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants