Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book chapter 1.2 futures::future::Future description #103

Open
MajorBreakfast opened this issue Aug 23, 2019 · 1 comment
Open

Book chapter 1.2 futures::future::Future description #103

MajorBreakfast opened this issue Aug 23, 2019 · 1 comment
Labels
accepted Accepted changes and pull requests that can be implemented or merged documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@MajorBreakfast
Copy link

First, thanks a lot for this great library and it's accompanying documentation!

This description of std::future::Future form the book sounds not quite correct:

In some sense, the std::future::Future can be seen as a minimal subset of futures::future::Future

https://book.async.rs/overview/std-and-library-futures.html

Actually both traits are the same. It's just a reexport:

https://github.com/rust-lang-nursery/futures-rs/blob/cde791c00b8b9c4fd14a594855038a1bc4b6323e/futures-core/src/future/mod.rs#L7

@skade skade added the documentation Improvements or additions to documentation label Aug 26, 2019
@skade
Copy link
Collaborator

skade commented Aug 26, 2019

Yep, that should be changed. Futures provides a much richer interface, but as a library.

@skade skade added accepted Accepted changes and pull requests that can be implemented or merged good first issue Good for newcomers labels Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted changes and pull requests that can be implemented or merged documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants