Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP smoke testing #407

Closed
yoshuawuyts opened this issue Oct 29, 2019 · 2 comments · Fixed by #429

Comments

@yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Oct 29, 2019

Currently our system isn't running automated tests for TCP. We should at least have some smoke tests for:

  • async_std::net::TcpListener + std::net::TcpStream (test tcp server)
  • async_std::net::TcpStream + std::net::TcpListener (test tcp client)

There's an empty tests/tcp.rs file which we could use to fill in. This should be quite straight forward when basing it on the examples. The only tricky part would be how to do shutdown, but dropping a task should work well enough here (: Marking this as a good first issue!

@markhildreth

This comment has been minimized.

Copy link
Contributor

@markhildreth markhildreth commented Oct 31, 2019

It seems that tests/tcp.rs is not empty, but does already does have some tests in it, although none of them appear to be using the std library's TcpStream/TcpListener. To be more specific, are you looking for a test or two that has an async_std stream connect to a std listener, and a std stream connect to an async_std listener?

@markhildreth

This comment has been minimized.

Copy link
Contributor

@markhildreth markhildreth commented Oct 31, 2019

I've added #429 based on my assumption of the requirements. Please let me know if I've misunderstood the requirements. If so, I can make revisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.