Skip to content

Deny warnings on CI #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2019
Merged

Deny warnings on CI #378

merged 2 commits into from
Oct 23, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Oct 22, 2019

No description provided.

@taiki-e taiki-e requested review from yoshuawuyts and a user October 22, 2019 07:05
skade
skade approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@skade skade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: There's only one interface change in there (PathBuf deriving Default), which brings async-std to parity with std.

r+ bors

@taiki-e taiki-e merged commit 2abf5ca into async-rs:master Oct 23, 2019
@taiki-e taiki-e deleted the warnings branch October 23, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skade skade skade approved these changes

@yoshuawuyts yoshuawuyts Awaiting requested review from yoshuawuyts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @skade