Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WriteFmtFuture must_use #628

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Make WriteFmtFuture must_use #628

merged 1 commit into from
Dec 16, 2019

Conversation

fenhl
Copy link
Contributor

@fenhl fenhl commented Dec 14, 2019

Fixes #627. Thanks to @jebrosen for pointing out the location of the issue.

Fixes async-rs#627. Thanks to @jebrosen for pointing out the location of the issue.
@fenhl
Copy link
Contributor Author

fenhl commented Dec 15, 2019

CI failure appears to be unrelated.

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently working on fixing CI. This patch looks great though. Thanks heaps!

@yoshuawuyts yoshuawuyts merged commit cac4e08 into async-rs:master Dec 16, 2019
@fenhl fenhl deleted the patch-1 branch December 16, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing must_use for writeln on File
2 participants