feat: do not require default feature for unstable #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2019
yoshuawuyts
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Overall in favor of this change. @dignifiedquire looks like CI is failing though; would you mind rebasing? -- recently fixed CI on master, which hopefully will make this pass again!
dignifiedquire
force-pushed
the
feat/unstable-without-default
branch
from
530117d
to
5bf3d95
Compare
|
@yoshuawuyts all fixed |
yoshuawuyts
approved these changes
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the unstable features, without accidentally enabling the runtime.