Use take_while instead of scan in impl of Product, Sum and FromStream for Option and Result
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegnn
changed the title
take_while instead of scan for impl of Product, Sum and FromStream for Optiontake_while instead of scan in impl of Product, Sum and FromStream for Option
yoshuawuyts
reviewed
Jan 14, 2020
yoshuawuyts
reviewed
Jan 15, 2020
|
@yoshuawuyts I finally rewrote |
olegnn
force-pushed
the
option_take_while
branch
from
770c04d
to
ed7ddac
Compare
olegnn
changed the title
take_while instead of scan in impl of Product, Sum and FromStream for Optiontake_while instead of scan in impl of Product, Sum and FromStream for Option and Result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
take_whileinstead ofscanis much clear becausetake_whileis designed for this kind of tasksscanstate