Changing task::block_on to park after a single poll #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 19, 2020
This was previously discussed in async-rs#605 and others as a source of high CPU load when sleeping tasks because of the overhead created by retrying a future in short succession.
spacekookie
force-pushed
the
immediate-parking
branch
from
71e1259
to
3dc2790
Compare
|
Looks like there's an unused import of `std::thread` that makes CI
fail, otherwise looks good to me! :)
I updated the branch.
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously discussed in #605 and others as a source of high
CPU load when sleeping tasks because of the overhead created by
retrying a future in short succession.
Personally I've noticed this behaviour as well, but wasn't able to
recreate test settings since making this change yet. Maybe someone
else has some good benchmarks to run.