Remove stdio lock methods #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Jun 4, 2020
|
I personally don't think it's possible to have a correct implementation that inter-ops with standard library's locks because of standard library's choice to have a reentrant mutex. It may be possible to skip the standard library, and directly call C API directly. This should be sound on POSIX platforms (I'm not sure about non-POSIX platforms). Sure, it may lead to garbage reads and writes (https://pubs.opengroup.org/onlinepubs/9699919799/functions/read.html says that "The behavior of multiple concurrent reads on the same pipe, FIFO, or terminal device is unspecified") when sync I/O operations and async I/O operations are combined, but strictly speaking that's not unsafe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805.