Add TcpListener::into_incoming #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Oct 18, 2021
yoshuawuyts
reviewed
Nov 29, 2021
| /// # Ok(()) }) } | ||
| /// ``` | ||
| #[cfg(feature = "unstable")] | ||
| pub fn into_incoming(self) -> impl Stream<Item = io::Result<TcpStream>> + Send { |
There was a problem hiding this comment.
This ideally would be a named future; but perhaps we can fix that in a follow-up PR?
yoshuawuyts
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #981.
async_iofor the implementation. I suggest implementing it here right now untilasync_ioadds the method too.impl Stream<_>as return type instead of a customIntoIncomingstruct, because the code is cleaner (IMO) and also removes one level of pointer indirection. Also, this is whatasync_iodoes.CC @yoshuawuyts