Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build with rustc 1.73 #56

Open
sdroege opened this issue Jan 31, 2024 · 4 comments · May be fixed by #57
Open

Doesn't build with rustc 1.73 #56

sdroege opened this issue Jan 31, 2024 · 4 comments · May be fixed by #57

Comments

@sdroege
Copy link
Contributor

sdroege commented Jan 31, 2024

error[E0446]: crate-private type `Conn<'a>` in public interface
  --> src/rusttls/stream.rs:13:5
   |
13 |     pub conn: Conn<'a>,
   |     ^^^^^^^^^^^^^^^^^^ can't leak crate-private type
...
17 | pub(crate) enum Conn<'a> {
   | ------------------------ `Conn<'a>` declared as crate-private

error[E0446]: crate-private type `Conn<'a>` in public interface
   --> src/rusttls/stream.rs:127:5
    |
17  | pub(crate) enum Conn<'a> {
    | ------------------------ `Conn<'a>` declared as crate-private
...
127 |     pub fn new(io: &'a mut IO, conn: impl Into<Conn<'a>>) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak crate-private type

This is just cargo +1.73 check in this repository.

@dignifiedquire
Copy link
Member

which version are you using? I can build master with 1.75 without issues

@sdroege
Copy link
Contributor Author

sdroege commented Jan 31, 2024

1.73. It builds fine with 1.75

@dignifiedquire
Copy link
Member

very strange

@sdroege
Copy link
Contributor Author

sdroege commented Jan 31, 2024

It's the same with 1.70, FWIW. I don't have older versions of the toolchain installed right now.

@zazabe zazabe linked a pull request Apr 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants