Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo fmt to travis build config #28

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Add cargo fmt to travis build config #28

merged 2 commits into from
Jul 14, 2020

Conversation

Atul9
Copy link
Contributor

@Atul9 Atul9 commented Jul 12, 2020

No description provided.

@yoshuawuyts
Copy link
Collaborator

@Atul9 Thanks for this PR! It seems this breaks CI on cargo fmt -- could you also run cargo fmt over the codebase so that CI is green? Thanks!

@Atul9
Copy link
Contributor Author

Atul9 commented Jul 13, 2020

Hi @yoshuawuyts should I open a new PR for the code changes from running cargo fmt? OR include those changes in this PR?

@yoshuawuyts
Copy link
Collaborator

@Atul9 feel free to include those here!

@Atul9
Copy link
Contributor Author

Atul9 commented Jul 13, 2020

@yoshuawuyts done, I have updated the PR & the build has passed.

yoshuawuyts
yoshuawuyts approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks so much!

@yoshuawuyts yoshuawuyts merged commit dc1b3b2 into async-rs:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atul9 @yoshuawuyts