Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implement new Parser-js interface + migrate to TypeScript #168

Merged
merged 13 commits into from
Mar 10, 2023
Merged

feat!: implement new Parser-js interface + migrate to TypeScript #168

merged 13 commits into from
Mar 10, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Oct 19, 2022

Description

This PR updates the current parser by:

Related issue(s)
Fixes #166

github-actions[bot]
github-actions bot reviewed Oct 19, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

smoya
smoya commented Oct 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@smoya smoya marked this pull request as draft October 19, 2022 20:12
@smoya smoya mentioned this pull request Oct 19, 2022
Merged
@smoya smoya marked this pull request as ready for review October 21, 2022 09:37
@smoya smoya mentioned this pull request Oct 21, 2022
Closed
dalelane
dalelane reviewed Oct 24, 2022
View reviewed changes
.eslintrc Show resolved Hide resolved
dalelane
dalelane approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(and a nudge that I need to get better at TS 😀 )

@smoya
Copy link
Member Author

smoya commented Oct 25, 2022

@magicmatatjahu would you mind reviewing this? 🙏

magicmatatjahu
magicmatatjahu reviewed Oct 25, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
test/avro-schema-parser.spec.ts Show resolved Hide resolved
derberg
derberg reviewed Oct 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
smoya and others added 2 commits October 26, 2022 10:23
@smoya @magicmatatjahu
Update src/index.ts
2d64d4b 
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
@smoya @magicmatatjahu
Update src/index.ts
49d3455 
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya smoya requested review from magicmatatjahu and removed request for fmvilas, M3lkior and asyncapi-bot-eve October 26, 2022 09:53
@smoya
Copy link
Member Author

smoya commented Oct 27, 2022

@derberg smells fixed

@smoya smoya requested review from magicmatatjahu and removed request for derberg October 27, 2022 11:29
magicmatatjahu
magicmatatjahu reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@smoya
Copy link
Member Author

smoya commented Oct 27, 2022

😅

😝 Fixed

@smoya smoya requested review from magicmatatjahu and derberg and removed request for magicmatatjahu October 27, 2022 19:48
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

magicmatatjahu
magicmatatjahu approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's ok, but lets see what codeowners will say :)

@smoya
Copy link
Member Author

smoya commented Nov 8, 2022

@derberg @M3lkior @fmvilas as code owners, would any of you mind doing a review to this? @dalelane already approved but more 👀 are needed. Thanks!

derberg
derberg reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please clarify what is the release strategy for these schema parsers for parser 2.0 ?

this PR points to next-major and 2.0 release candidate will be generated. Then the RC will be used in the generator?

@derberg derberg mentioned this pull request Nov 14, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 9, 2023
@smoya
Copy link
Member Author

smoya commented Mar 9, 2023

still relevant

@M3lkior
Copy link
Collaborator

M3lkior commented Mar 9, 2023

can you please clarify what is the release strategy for these schema parsers for parser 2.0 ?

this PR points to next-major and 2.0 release candidate will be generated. Then the RC will be used in the generator?

there is a WIP PR to use it from the generator: asyncapi/generator#833

@M3lkior
Copy link
Collaborator

M3lkior commented Mar 9, 2023

Just a last rebase is needed from next-major @smoya :)

@github-actions github-actions bot removed the stale label Mar 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya
Copy link
Member Author

smoya commented Mar 10, 2023

Just a last rebase is needed from next-major @smoya :)

@M3lkior Code is now up-to-date now. I also updated the parser-js package to the latest 2.0 prerelease.

@M3lkior M3lkior merged commit 5c1bb01 into asyncapi:next-major Mar 10, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@smoya smoya mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg left review comments

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@dalelane dalelane dalelane approved these changes

Assignees
No one assigned
Labels
released on @next-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@smoya @derberg @M3lkior @asyncapi-bot @dalelane @magicmatatjahu