-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add schema registry infos to Kafka binding #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone using schemas (and a schema registry) could use that to serialize a message key, the message payload, or both.
Is the assumption here that schema-related bindings settings relate to message payload only?
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@lbroudoux do you plan to continue with this one? |
Yep. Sorry for the long time no see. Will have more free cycles now 😉 |
Push a new commit to update to latest spec version. |
…eplicas at the channel level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@KhudaDad414 @dratasich would you mind looking into this PR again? Thanks! |
Thanks @lbroudoux - I like and appreciate the outcome. From my point of view very useful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a small typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch on the typo :)
@derberg this PR is made against |
👏 🎉 |
Description
As of today, there's no way using
0.2.0
version of Kafka bindings to provide information on whether a Schema Registry was/has to be used to provide/gather schema information for messages published on topics.However, such information is required to help on two use-cases:
Use-cases and needed informations have been discussed with @nictownsend and @dalelane. This PR is aggregating validated propositions. The proposition is to add following attributes:
At the
server
level:schemaRegistryUrl
- API URL for the Schema Registry used when producing Kafka messagesschemaRegistryVendor
- he vendor of Schema Registry and Kafka serdes library that should be usedAt the
operation
level:schemaIdLocation
- Tells where the id of schema is stored (e.g.header
orpayload
)schemaIdPayloadEncoding
- Number of bytes or vendor specific values when schema id is encoded in payloadschemaLookupStrategy
- Freeform string for any naming strategy class to use. Clients should default to the vendor default if not supplied.Related issue(s)
This PR is related to #40 and #41. It has been initially discussed into PR #55 but finally close due to inactivity.