-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: created hook to load spec file #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if you changed PR from draft to open I can make the review :) Overall good, but please refer to my comments.
I deleted my dist folder then ran the tests again, all tests are passing. |
I run tests in the mac, and sometimes they fail, so probably we have some bugs in tests. |
Hey, @magicmatatjahu is this PR good to go. |
The node ./dist/cli.js validate --file ./spec.yaml then CLI validates the spec from current context. You have missed changes in https://github.com/asyncapi/cli/blob/master/src/CliModels.ts#L35 file.` Please update the indentations in the help command, because at the moment it looks like: and update the Readme.md with new Btw, overall good, except that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Souvikns Please also update the package-lock :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome work! |
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
--context
flag to load from the contexts.asyncapi validate
Related issue(s)
Fixes #20