-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(design): implement design system for generate command #1302
Conversation
@Mayaleeeee could you please confirm if the following is according to your design or needs something to be changed. cc: @Amzani |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR @Shurtu-gal 🚀 , I added few small suggestion.
@Amzani I have applied the suggestions. |
Thanks for tagging @Shurtu-gal. Firstly, I'd like to clarify: is the design above intended to display two variations? I notice 'AsyncAPI Generate Models' appearing twice with nearly identical content. As per my design, when users input 'AsyncAPI Generate Models,' the prompt should be 'Name of the programming language?' instead of what's shown in the image. |
No it is the same variant, just that initially it will be a select and then the above one when a language has been selected. |
Understood, thanks for clarifying that. However, you didn't address the second part, which is whether the image you provided aligns with my design. |
It can be changed easily; however name of the programming language expects a string to be given as an input, that's why I used select. |
I also believe that "Select the language..." is better than "Name of the programming language" because the first one is telling you what action to do, i.e., "select". Just my two cents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yeah, I think you should do that. |
Great !! |
@Shurtu-gal you have some conflicts, can you resolve them before I approve? |
@Souvikns done! |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/rtm |
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@asyncapi/bounty_team |
Description
Related issue(s)
See #1214