Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: valid Example URL based on parser version #213

Closed
wants to merge 4 commits into from
Closed

fix: valid Example URL based on parser version #213

wants to merge 4 commits into from

Conversation

imabp
Copy link
Member

@imabp imabp commented Feb 6, 2022

Description

  • Implements getValidExampleZipURL to fetch right version of Example Specification based on parserVersion

Related issue(s)
Fixes : #205

@imabp imabp changed the title fix: Valid Example Zip URL fix: valid Example URL based on parser. Feb 6, 2022
@imabp imabp changed the title fix: valid Example URL based on parser. fix: valid Example URL based on parser version Feb 6, 2022
@imabp imabp marked this pull request as draft February 8, 2022 17:53
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented May 24, 2022

yo, just wanted to tell you that we do not look into drafts, as they are drafts, unless you explicitly call out a maintainer. Just letting you know as I see you from time to time update PR with latest master, but do not commit any changes

@derberg
Copy link
Member

derberg commented Jul 12, 2022

@imabp do you plan to continue with this PR, so far it is Draft so nobody will look into it unless you ping someone

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@derberg
Copy link
Member

derberg commented Nov 17, 2022

closing in favour of #390

@derberg derberg closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching examples from master causes errors during release
2 participants