-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce monorepo with filters package included #1155
Conversation
docs: clarify paho version & fix typo (#1146)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is huge
can we introduce the change at least in 2 PRs? like first add generator-filters
and then move generator
to apps? cause now you just did moved all other files inside apps/generator
but without checking if it makes sense, like for example all GitHub workflows
@derberg should i convert the generator into turborepo. on its own. first . which means adding generator to the apps directory before as that would make sense. Also prs of merging the repos will be expected to be huge even though i add one at time in a single pr. cause i am also merging the commits. |
@ayushnau yeah, I know they will be big, we just need to figure some approach maybe that can show that new files that are added are not modified or something like that, so review is smooth but yeah, in this particular PR I know that if you split in 2 it will be big anyway, but seeing you moving GH actions workflows inside apps made me think we need to do one app at a time |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/generator/.all-contributorsrc
must stay in the root- same sonar clound properties config - should be one for all apps
- same eslint and editor config files right?
- same files like codeowners or code of conduct, license, contri guide
- same readme banner
- also readme seems to be duplicated
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please lemme know once you make changes and resolve conflicts
Quality Gate passedIssues Measures |
Acutually i was not able to get the changes in my branch. so need to refork it. |
This pr is moved to this #1186 |
Changes Added.
Related issue(s)
Resolves #1044