Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce monorepo to Generator Repo #1213

Merged
merged 26 commits into from
Jun 20, 2024
Merged

refactor: introduce monorepo to Generator Repo #1213

merged 26 commits into from
Jun 20, 2024

Conversation

ayushnau
Copy link
Contributor

Changes Added.

  1. Turborepo Added.
  2. Converted the generator repo to app, inside the turborepo.
  3. Added the required scripts of the turborepo to the root package.json file.

Related issue(s)

Resolves #1044

@aeworxet
Copy link

@asyncapi/bounty_team

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label May 23, 2024
@AyushNautiyalDeveloper
Copy link

image

@derberg please check added the required lint change.

@derberg
Copy link
Member

derberg commented May 23, 2024

@ayushnau
Copy link
Contributor Author

let me check though i have fixed these in the local.

@derberg
Copy link
Member

derberg commented May 23, 2024

@ayushnau I see linter complains on files from /home/runner/work/generator/generator/apps/generator/test/test-templates/react-template/__transpiled/test-file.md.js but it should not as these should be ignored

so basically make sure that eslint ignores /apps/generator/test/test-templates/react-template/__transpiled

@derberg
Copy link
Member

derberg commented May 23, 2024

I see it is there already in .eslintignore but you most probably need to update lint scripts to point to ignore file in root

@ayushnau
Copy link
Contributor Author

@derberg I have already pushed the changes for eslintignore can you check.

@derberg
Copy link
Member

derberg commented Jun 12, 2024

@ayushnau
Copy link
Contributor Author

Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ayushnau
Copy link
Contributor Author

image image @derberg please check updated and added the required chagnes for the release.

Copy link

sonarcloud bot commented Jun 20, 2024

@derberg derberg changed the title feat: introduce monorepo to Generator Repo refactor: introduce monorepo to Generator Repo Jun 20, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are ready to go.

generator is still the same as it was before this PR, it is just in a different directory.

tests are passing!

.releaserc is properly updated, so semantic-release npm plugin should know what to do - in theory 😄

I change PR title to refactor as we do not really have to make a test now to check if new semantic-release config works as anyway next PR will introduce changelog instead of semantic-release. Other PRs that are now in progress will have to adjust to new master and they will be guinea pigs for release pipeline

@derberg
Copy link
Member

derberg commented Jun 20, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit bc9dbec into asyncapi:master Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label ready-to-merge
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

How about a monorepo 😄
6 participants