Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prettier lint config and refactor the files #469

Merged
merged 4 commits into from
Jul 5, 2023
Merged

feat: add prettier lint config and refactor the files #469

merged 4 commits into from
Jul 5, 2023

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Jul 5, 2023

Description

This PR is trying to fix the linting issue with #460 and currently #404 is blocking us, If this PR opens up then we can close this one.

I went with the very basic configuration, feel free to suggest any other configurations that we should add.

trailingComma: "es5"
tabWidth: 2
semi: false
singleQuote: true

Related issue(s)

Fixes #398

@coveralls
Copy link

coveralls commented Jul 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5463500174

  • 80 of 117 (68.38%) changed or added relevant lines in 11 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 60.58%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/message.ts 0 1 0.0%
src/lib/util.ts 9 10 90.0%
src/middlewares/existsInAsyncAPI.ts 4 5 80.0%
src/lib/cluster.ts 13 15 86.67%
src/lib/glee.ts 11 13 84.62%
src/lib/adapter.ts 15 19 78.95%
src/lib/configs.ts 6 19 31.58%
src/lib/logger.ts 6 19 31.58%
Files with Coverage Reduction New Missed Lines %
src/lib/adapter.ts 1 76.25%
src/lib/cluster.ts 2 79.01%
src/lib/configs.ts 2 18.68%
src/lib/logger.ts 6 12.39%
Totals Coverage Status
Change from base Build 5412733752: 0.05%
Covered Lines: 331
Relevant Lines: 465
💛 - Coveralls

KhudaDad414
KhudaDad414 previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns
Copy link
Member Author

Souvikns commented Jul 5, 2023

😄 sorry @KhudaDad414 need your review again.

KhudaDad414
KhudaDad414 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@Souvikns
Copy link
Member Author

Souvikns commented Jul 5, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit f65a7a0 into asyncapi:master Jul 5, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KhudaDad414 KhudaDad414 mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhudaDad414 KhudaDad414 KhudaDad414 approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add prettier configuration
4 participants
@Souvikns @coveralls @asyncapi-bot @KhudaDad414