Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Scala generator to playground #1773

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

akkshitgupta
Copy link
Collaborator

Description

This pull request adds the functionality of generating Scala models in the playground for the user to play around.

Related Issue fixes: #1690

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Screenshots:

Before After
Screenshot-0 Screenshot-1

Screenshot-2

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 49d598b
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65bb36d11dcc6700084efb3d

@coveralls
Copy link

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 7737075232

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.289%

Totals Coverage Status
Change from base Build 7735998091: 0.0%
Covered Lines: 5994
Relevant Lines: 6328

💛 - Coveralls

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akkshitgupta Can you please check out why deploy preview is failing?

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akkshitgupta Looks good to me!

@devilkiller-ag
Copy link
Member

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @devilkiller-ag! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@devilkiller-ag
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit eb34832 into asyncapi:master Feb 1, 2024
16 of 17 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Scala generator to playground
4 participants