You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code follows the project's coding standards and is properly linted (npm run lint).
Tests have been added or updated to cover the changes.
Documentation has been updated to reflect the changes.
All tests pass successfully locally.(npm run test).
Additional Notes
This PR is the extension of PR #1785. The initial base has been built from Async API CLI. Now we need to add rectify all the tests, do clean-ups, and integrate this Modelina CLI with Modelina CLI.
@devilkiller-ag we each can now make PRs that target the cli branch, and we just collaborate ✌️ You continue exactly as you have been doing, lets just stick to small changes so we dont duplicate work as much as possible 🙂How does that sound?
@jonaslagoni Seems good to me! But the Runtime test for Rust, Kotlin, and Scala Model is still failing. Is it fine for merging to next with these issues?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devilkiller-ag
changed the title
jonaslagoni
requested review from
magicmatatjahu,
jonaslagoni,
kennethaasan and
asyncapi-bot-eve
as code owners
Description
Modelina and integrate it with AsyncAPI CLI
Related Issue
Related to issue #1724 and PR #1785
Checklist
npm run lint).npm run test).Additional Notes
This PR is the extension of PR #1785. The initial base has been built from Async API CLI. Now we need to add rectify all the tests, do clean-ups, and integrate this Modelina CLI with Modelina CLI.