Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use snake case for file names in go #1894

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

kennethaasan
Copy link
Collaborator

Description

This MR enforces go file names to be in snake_case format. This is considered best practice in golang: golang/go#36060

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 5fadd4a
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65f2cf9791b361000873ce96

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kennethaasan
Copy link
Collaborator Author

/rtm

@jonaslagoni jonaslagoni merged commit cbb2410 into asyncapi:next Mar 14, 2024
15 checks passed
@kennethaasan kennethaasan deleted the golang-file-names branch March 14, 2024 10:42
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants