fix: change metadata of models and fix minor things #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
bug
magicmatatjahu
requested review from
fmvilas,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
magicmatatjahu
commented
Oct 27, 2022
| if (typeof additionalItems === 'boolean') return additionalItems; | ||
| if (additionalItems === undefined) return true; | ||
| if (additionalItems === null) return false; | ||
| if (additionalItems === undefined || additionalItems === null) return; |
There was a problem hiding this comment.
We have to be consistent with implementation in v1 parser - current logic in next-major has breaking change in additionalItems and additionalProperties methods and some templates won't work.
There was a problem hiding this comment.
smoya
reviewed
Oct 27, 2022
| @@ -2,6 +2,5 @@ import type { BaseModel } from './base'; | |||
|
|
|||
| export interface ExtensionInterface<T = any> extends BaseModel { | |||
| id(): string; | |||
| version(): string; | |||
There was a problem hiding this comment.
Please ensure this change is proposed in asyncapi/parser-api#71
There was a problem hiding this comment.
Done asyncapi/parser-api#71 (comment) :)
smoya
reviewed
Oct 27, 2022
smoya
approved these changes
Oct 27, 2022
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@smoya Thanks! |
|
/rtm |
|
🎉 This PR is included in version 2.0.0-next-major.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
inputto theasyncapimetadata of models.sourcein model metadata now points to the source of file/document, not to the input.x-parser-schema-idso I will add proper if insetExtensionfunction.validateandparsefunctions.version()method fromExtensionmodel - we don't have clarified it in spec, so we shouldn't add that in current api.additionalItemsandadditionalPropertiesmethods from old Schema model - we havw to consistent with old logic.cc @smoya