Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update next-spec branch with master changes #249

Merged

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Sep 12, 2022

This is PR is part of asyncapi/spec#830 and updates next-spec branch with changes from master.

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n char0n mentioned this pull request Sep 12, 2022
61 tasks
@char0n
Copy link
Collaborator Author

char0n commented Sep 12, 2022

@fmvilas @derberg @dalelane would you mind reviewing this PR please? Thanks

Verification question - I've created this PR by merging master branch with next-spec and issuing a PR containing the merges + a merge commit. There are other ways to achieve the same. Is there any preference in how to achieve the goal of updating the next-spec branch from master? If yes please let me know.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@char0n we did not standardize the flow here. I would also just merge master into next.

I think we should consider having a workflow that will always keep next branches up to date with master, on a regular basis between releases. This can be automated with https://github.com/marketplace/actions/update-git-branch and means one manual step less.. Just put it as followup release process improvement actions after release.

@derberg
Copy link
Member

derberg commented Sep 13, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 6f264fb into asyncapi:next-spec Sep 13, 2022
@char0n
Copy link
Collaborator Author

char0n commented Sep 14, 2022

@char0n we did not standardize the flow here. I would also just merge master into next.

ACKN.

I think we should consider having a workflow that will always keep next branches up to date with master, on a regular basis between releases. This can be automated with https://github.com/marketplace/actions/update-git-branch and means one manual step less.. Just put it as followup release process improvement actions after release.

Added in asyncapi/spec#830

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.15.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants