refactor: update schema to resolve reference property issue #275
Conversation
mastdev
requested review from
fmvilas,
derberg,
dalelane,
smoya,
char0n and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
@jonaslagoni I'm wondering if it makes sense to backport to previous versions 🤔 it is rather refactor work that an actuall fix
definitions/2.5.0/parameters.json
Outdated
| "oneOf": [ | ||
| { | ||
| "$ref": "http://asyncapi.com/definitions/2.5.0/parameter.json" | ||
| } | ||
| ] |
There was a problem hiding this comment.
| "oneOf": [ | |
| { | |
| "$ref": "http://asyncapi.com/definitions/2.5.0/parameter.json" | |
| } | |
| ] | |
| "oneOf": [ | |
| { | |
| "$ref": "http://asyncapi.com/definitions/2.5.0/Reference.json" | |
| }, | |
| { | |
| "$ref": "http://asyncapi.com/definitions/2.5.0/parameter.json" | |
| } | |
| ] |
There was a problem hiding this comment.
Made the changes with the commit #cdee75e. Kindly review.
|
@mastdev yo, wanted to check if you saw my review |
|
Sorry, been inactive for a while. Thanks, @derberg for the review. Will incorporate the changes in the following commit. |
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
lgtm
@jonaslagoni since you reported the issue, I want to make sure you are happy with the outcome
|
/rtm |
|
@mastdev thanks a lot for your contribution there are few more similar issues https://github.com/asyncapi/spec-json-schemas/issues?q=is%3Aissue+is%3Aopen+label%3AHacktoberfest if you would like to help more |
|
Thanks, @derberg for the opportunity. I am new to Open Source and it feels great to have one of my initial PRs merged. 😃 |
|
@mastdev congrats 😄 and thanks for helping us here 🙇🏼 |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
paramter.jsonandparameters.jsonRelated issue(s)
Resolves #165