Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP Message Exchange #41

Closed
gmr opened this issue Oct 26, 2017 · 4 comments · Fixed by #170
Closed

AMQP Message Exchange #41

gmr opened this issue Oct 26, 2017 · 4 comments · Fixed by #170
Assignees
Labels

Comments

@gmr
Copy link

gmr commented Oct 26, 2017

I noticed there is no construct for an exchange in AMQP. It would be nice to have that explicitly called out somehow.

@fmvilas
Copy link
Member

fmvilas commented Oct 27, 2017

Must confess that I thought about it but rejected the idea of including it since exchanges are not part of the AMQP protocol spec (are they?) and they are not something common in messaging systems. I would suggest you use specification extensions for that purpose. Example:

x-exchange: my-exchange

And then, it could be part of docs and code generators (and other software) only if the protocol is amqp.

@fmvilas
Copy link
Member

fmvilas commented Oct 27, 2017

We could use the feature suggested in #42 to solve this problem.

@fmvilas
Copy link
Member

fmvilas commented Nov 12, 2017

This will be addressed in version 2 because it's a breaking change.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants